Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dont assume bytes type #25

Open
3052 opened this issue Apr 11, 2024 · 0 comments
Open

dont assume bytes type #25

3052 opened this issue Apr 11, 2024 · 0 comments
Labels
help wanted Extra attention is needed

Comments

@3052
Copy link

3052 commented Apr 11, 2024

using this file:

https://github.com/protocolbuffers/protoscope/files/14941355/hello.dmp

I get this result:

> protoscope hello.dmp
1: {12: 9.155902e11i32}   # 0x53552d6ei32

while with other methods I get this result:

protobuf.Message{
   protobuf.Field{Number:1, Type:2, Value:protobuf.Bytes("en-US")},
   protobuf.Field{Number:1, Type:2, Value:protobuf.Message{
      protobuf.Field{Number:12, Type:5, Value:protobuf.Fixed32(1398091118)},
   }},
}

I think it would be useful if protoscope didn't assume type, and just return bytes as is, and also as embedded message, if it parses as such

@esorot esorot added the help wanted Extra attention is needed label Jul 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants