Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Linter counts immutable vars as state vars #258

Closed
gitpusha opened this issue Oct 19, 2020 · 4 comments · Fixed by #267
Closed

Linter counts immutable vars as state vars #258

gitpusha opened this issue Oct 19, 2020 · 4 comments · Fixed by #267
Assignees
@fernandomg
Labels
bug

Comments

@gitpusha
Copy link

Hi,

For the max-states-count rule, the linter counts immutable vars as state variable declarations, which shouldnt be the case, right?

See:
image
@fvictorio
Copy link
Contributor

image

@fvictorio
Copy link
Contributor

Pretty sure it's a bug tho

@fvictorio fvictorio added the bug label Oct 19, 2020
@gitpusha
Copy link
Author

Yeah, I guess the rule was invented with saving on sloads/sstores in mind, right?

@fvictorio
Copy link
Contributor

That rule is before my time, but maybe? I always interpreted it as "don't make contracts that are too complex"

@fernandomg fernandomg mentioned this issue Oct 28, 2020
Merged
@fernandomg fernandomg self-assigned this Oct 28, 2020
This was referenced Mar 6, 2021
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@fernandomg fernandomg

Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Avoid counting immutable for the max-state-count rule protofire/solhint
3 participants
@fvictorio @fernandomg @gitpusha