Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove "not-rely-on-time" from the recommended ruleset #350

Closed
PaulRBerg opened this issue Jul 17, 2022 · 2 comments · Fixed by #407
Closed

Remove "not-rely-on-time" from the recommended ruleset #350

PaulRBerg opened this issue Jul 17, 2022 · 2 comments · Fixed by #407
Labels
breaking-change

Comments

@PaulRBerg
Copy link
Contributor

As discussed here and here, and shown in practice by many dapps like Sablier which do rely on time, block.timestamp is safe to use.
@PaulRBerg PaulRBerg mentioned this issue Feb 17, 2023
Merged
@PaulRBerg
Copy link
Contributor Author

This issue has to be reopened as per @fvictorio's comment here.

@dbale-altoros dbale-altoros reopened this Feb 21, 2023
@dbale-altoros dbale-altoros mentioned this issue Feb 21, 2023
Merged
@fvictorio fvictorio changed the title Suggestion to change the default for the "not-rely-on-time" rule to "off" Remove "not-rely-on-time" from the recommended ruleset Feb 22, 2023
@dbale-altoros
Copy link
Collaborator

This will be modified in next release
#479
Marked as braking change

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
breaking-change
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

refactor: set "not-rely-on-time" to "off" by default PaulRBerg/solhint
3 participants
@fvictorio @PaulRBerg @dbale-altoros