Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

option go_package bug #40

Open
Rkiouak opened this issue Feb 28, 2020 · 1 comment
Open

option go_package bug #40

Rkiouak opened this issue Feb 28, 2020 · 1 comment

Comments

@Rkiouak
Copy link
Member

Rkiouak commented Feb 28, 2020

Given a foo.proto importing another bar.proto, if bar.proto uses a go_package option, the require of the bar ns in the foo ns will be output as [ :as ]

This is either related to our not ignoring go_package, or the CodeGenRequest including the go_package under a separate key that we don't ignore or handle properly.
@Rkiouak
Copy link
Member Author

Rkiouak commented Feb 28, 2020

https://github.com/Rkiouak/go-package-import-reproduction reproduces this issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Rkiouak