Skip to content

Commit

Permalink
deprecate max_deviation and clearance
Browse files Browse the repository at this point in the history
  • Loading branch information
TitusLabs committed Jun 28, 2023
1 parent 9bb66a6 commit e1755d8
Showing 1 changed file with 2 additions and 0 deletions.
2 changes: 2 additions & 0 deletions z_calibration.py
Original file line number Diff line number Diff line change
Expand Up @@ -19,11 +19,13 @@ def __init__(self, config):
self.switch_offset = config.getfloat('switch_offset', 0.0, above=0.)
# max_deviation is deprecated
self.max_deviation = config.getfloat('max_deviation', None, above=0.)
config.deprecate('max_deviation')
self.offset_margins = self._get_offset_margins('offset_margins',
'-1.0,1.0')
self.speed = config.getfloat('speed', 50.0, above=0.)
# clearance is deprecated
self.clearance = config.getfloat('clearance', None, above=0.)
config.deprecate('clearance')
self.safe_z_height = config.getfloat('safe_z_height', None, above=0.)
self.samples = config.getint('samples', None, minval=1)
self.tolerance = config.getfloat('samples_tolerance', None, above=0.)
Expand Down

2 comments on commit e1755d8

@Tenkir
Copy link

@Tenkir Tenkir commented on e1755d8 Nov 28, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

config.deprecate('max_deviation')

Deprecated in favor of what? Is there a replacement?

@TitusLabs
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's the safe_z_height 👍

Please sign in to comment.