Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rome vs Vatican State #210

Open
wipfli opened this issue Jan 20, 2024 · 5 comments
Open

Rome vs Vatican State #210

wipfli opened this issue Jan 20, 2024 · 5 comments

Comments

@wipfli
Copy link
Collaborator

wipfli commented Jan 20, 2024

Location

https://maps.protomaps.com/#map=4.85/42/12.23&theme=light&renderer=maplibregl&tiles=https://build.protomaps.com/20240120.pmtiles

Screenshots

Screenshot_20240120-224622

Problem

The label of Rome, Italy's capital, gets collided away by the label of Vatican State. I think ot is because country labels always show before city labels. But Vatican should be rather treated as a quarter of Rome. So when zooming in I expect to see Rome and once I see the city outlines I expect to see Vatican too.

@bdon
Copy link
Member

bdon commented Jan 21, 2024

@nvkelso thoughts on how to resolve this without hardcoding an exception, based on NE data?

@wipfli
Copy link
Collaborator Author

wipfli commented Jan 21, 2024

General question: Are hardcoded exceptions actually that bad of an idea?

@nvkelso
Copy link
Collaborator

nvkelso commented Jan 22, 2024

Let's look in the style? major cities should be preferred over minor countries and minor cities. The min_zoom should already be setup for that in the data, but MapLibre's layer based label collisions sometimes necessitates splitting the rendering into different draw layers?

@lymperis-e
Copy link

This is a common problem in almost every Mapbox-GL derived style (screenshot from Maptiler below). Only Mapbox themselves seem to get it right.
image

@wipfli
Copy link
Collaborator Author

wipfli commented Feb 10, 2024

Are osm identifiers stable enough to use them as ids in an exceptions list? I think for stuff like this there is no other way than making exception lists...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants