Skip to content
This repository has been archived by the owner on Apr 7, 2021. It is now read-only.

[Feature Request]Reply shows only 'Write...' #15

Open
thuck opened this issue Jun 26, 2011 · 4 comments
Open

[Feature Request]Reply shows only 'Write...' #15

thuck opened this issue Jun 26, 2011 · 4 comments

Comments

@thuck
Copy link

thuck commented Jun 26, 2011

This is a feature request than a bug, but using the Compose to reply I got only 'Write...' in the tab title, would it be nice if some extra information could be showed like the subject, if its a reply or a fwd, since sometimes I let several tabs opened to answer later and it's hard to find out the one that I want to answer first.
It could be something like 'Reply [subject]'; 'Fwd [Subject]', and leave the 'Write...' only for news messages...

Thanks

@protz
Copy link
Owner

protz commented Jun 27, 2011

Are you running the 0.2 version? The "Write..." should change to
"Write... " followed by the subject as soon as you focus out of the
subject field. This sounds like an easy fix, and I'd gladly accept a
patch for this issue :-)

On Sun 26 Jun 2011 11:49:09 AM PDT, thuck wrote:

This is a feature request than a bug, but using the Compose to reply I got only 'Write...' in the tab title, would it be nice if some extra information could be showed like the subject, if its a reply or a fwd, since sometimes I let several tabs opened to answer later and it's hard to find out the one that I want to answer first.
It could be something like 'Reply [subject]'; 'Fwd [Subject]', and leave the 'Write...' only for news messages...

Thanks

@thuck
Copy link
Author

thuck commented Jun 27, 2011

Now I'm running the 0.3pre; and you are right it's not a difficult change, as the default configuration of thunderbird include the Re and Fwd in the begging of the subject should be enough, so I did a patch to have the subject in the title without the need of focus, also it will update the title after any change in the subject. Now I think I'm going to work on something to change favicon dynamically, so if it's a reply or a forward will be easier to identify, anyway below the patch, if you need it any different way by e-mail or something like that let me know.

From 807b17e7a39af71f78d954148bfe27dcfd1f3cf7 Mon Sep 17 00:00:00 2001
From: denis doria thuck@thuck
Date: Mon, 27 Jun 2011 08:34:30 -0300
Subject: [PATCH] Change the title of a tab without the need of focus, also
will update the tab title if the subject is change


content/stub.compose-ui.js | 2 ++
content/stub.html | 9 +++++++--
2 files changed, 9 insertions(+), 2 deletions(-)

diff --git a/content/stub.compose-ui.js b/content/stub.compose-ui.js
index 71efda8..4643dd3 100644
--- a/content/stub.compose-ui.js
+++ b/content/stub.compose-ui.js
@@ -248,11 +248,13 @@ ComposeSession.prototype = {
default:
break;
}
+
$("#subject").val(v);
let self = this;
$("#subject").change(function () {
self.modified = true;
});

  • document.title = v
    this._top();
    },

diff --git a/content/stub.html b/content/stub.html
index 340faaa..f7ce7cf 100644
--- a/content/stub.html
+++ b/content/stub.html
@@ -3,7 +3,7 @@

- <title>Write...</title> - <title>Write...</title> @@ -17,6 +17,11 @@ <script type="application/javascript;version=1.8" src="stub.compose-ui.js"></script> <script type="application/javascript;version=1.8" src="stub.completion-ui.js"></script> <script type="application/javascript;version=1.8" src="stub.ui.js"></script> - <script type="text/javascript"> - function change_title(id){ - document.title = $("#subject").val(); - } - </script> <script type="text/javascript"> //center div vertically and horizontally jQuery(function(){ jQuery(window).bind('load resize', function(){ @@ -79,7 +84,7 @@ subject:
- -
-- 1.7.5.4

@thuck
Copy link
Author

thuck commented Jun 27, 2011

hi protz, I cleanup the patch, since some parts that I included are not necessary for this modification, I uploaded it to the gist, I think it will be easier to get it from there, below the link:
https://gist.github.com/1049232

@protz
Copy link
Owner

protz commented Jun 27, 2011

Thanks! I'll look it into it real soon.

On Mon 27 Jun 2011 09:41:54 AM PDT, thuck wrote:

hi protz, I cleanup the patch, since some parts that I included are not necessary for this modification, I uploaded it to the gist, I think it will be easier to get it from there, below the link:
https://gist.github.com/1049232

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants