Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ability to provide a separate Message name for each topic when using ProtobufFile #849

Closed
zarezadeh opened this issue Sep 4, 2021 · 3 comments · Fixed by #854
Closed
Labels
type/enhancement En enhancement to an already existing feature
Milestone

Comments

@zarezadeh
Copy link
Contributor

Is your proposal related to a problem?

When using a protobufFile definition for parsing messages, it is assumed that all topics use a single message type. But this assumption is not valid in a lot of common scenarios IMO. It could be helpful to use a separate message type for each topic in a cluster.

Describe the solution you'd like

Instead of setting a single message name in protobufMessageName when configuring a cluster, use a map of topic -> messageName in order to have different message names for each topic. Also, we can use a predefined key in this map (e.g. _default) to set a message name for all other topics without explicit mapping.

Describe alternatives you've considered

Using Schema Registry is a better alternative when possible but in legacy deployments when messages in Kafka topics don't adhere to the format schema registry expects, this is not an option.

Additional context

I've already started working to prepare a PR, but I'd like to discuss the best solution before submitting the PR.

@zarezadeh zarezadeh added the type/enhancement En enhancement to an already existing feature label Sep 4, 2021
@germanosin
Copy link
Contributor

Hi, @zarezadeh. Thanks for creating this issue. We'll take this in the next version.

@germanosin germanosin added this to the 0.3 milestone Sep 6, 2021
@zarezadeh
Copy link
Contributor Author

It's great @germanosin, so if you are OK with the proposed solution I would prepare and send the PR very soon.

@germanosin
Copy link
Contributor

@zarezadeh . Great! I would be happy to review it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/enhancement En enhancement to an already existing feature
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants