You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The proto-push workflow is running on merges to main instead of as part of a release.
That means that our published protos don't necessarily represent our most recent release. This can also cause our proto checks to fail erroneously.
Example, #868 was merged to main which caused the new proto files to be pushed. But those protos weren't updated in the release/v1.11.x branch. So any PR based on the release/v1.11.x branch now fails the third-party proto breaking check. It's saying that things have been removed from the proto. But in fact, nothing has been removed, it's just that new additions were pushed up for comparison before they were part of a release.
Summary of Bug
The proto-push workflow is running on merges to main instead of as part of a release.
That means that our published protos don't necessarily represent our most recent release. This can also cause our proto checks to fail erroneously.
Example, #868 was merged to main which caused the new proto files to be pushed. But those protos weren't updated in the
release/v1.11.x
branch. So any PR based on therelease/v1.11.x
branch now fails the third-party proto breaking check. It's saying that things have been removed from the proto. But in fact, nothing has been removed, it's just that new additions were pushed up for comparison before they were part of a release.Version
cab33d8b
(and alsov1.11.1
).Steps to Reproduce
See https://github.com/provenance-io/provenance/actions/runs/2666663928
Proposed Solution
Move that job into the
release.yml
workflow and utilize the setup/variables in there to do that job during a release (instead of on push tomain
).For Admin Use
The text was updated successfully, but these errors were encountered: