Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Case Sensitivity for Commands and Filename #1325

Closed
AustinSaintAubin opened this issue Nov 10, 2018 · 4 comments
Closed

Case Sensitivity for Commands and Filename #1325

AustinSaintAubin opened this issue Nov 10, 2018 · 4 comments

Comments

@AustinSaintAubin
Copy link

AustinSaintAubin commented Nov 10, 2018

I am having an issue with the Prusa Firmware.
When sending the print file command the I have noticed that the firmware is case sensitive.
More details here: luc-github/ESP3D#273

FAIL

M23 PRINT~1.GCO
M24

WORKS

M23 test~1.gco
M24

This is also odd because the file list is output in UPPERCASE, but requires lowercase input.

M20

Begin file list
/STOCK/MK3_PL~1.GCO 319820
/STOCK/MK3_PL~2.GCO 23525291
/STOCK/MK3_PL~3.GCO 10256022
/STOCK/MK3_PL~4.GCO 1163600
/STOCK/MK3_PL~5.GCO 3771043
/STOCK/MK3_PR~1.GCO 409041
/STOCK/MK3_P~33.GCO 17819561
/STOCK/MK3_P~38.GCO 224162
/STOCK/MK3_P~42.GCO 25074366
/STOCK/MK3_P~46.GCO 5966830
/STOCK/MK3_P~50.GCO 9991779
/STOCK/MK3_P~54.GCO 839525
/STOCK/MK3_P~58.GCO 21788066
/STOCK/MK3_P~62.GCO 2206259
/STOCK/MK3_P~66.GCO 3552905
/STOCK/MK3_P~70.GCO 7586128
PRINT~1.GCO 12739152
/BENCHM~1/3DBENC~1.GCO 3670093
/BENCHM~1/TEST_Y~1.GCO 1247554
/BENCHM~1/RIPPLE~1.GCO 1064312
/CONTAI~1/SD_HOL~1.GCO 130043
/CONTAI~1/SD_ADA~1.GCO 1132984
/CONTAI~1/SOAP_H~1.GCO 5925818
/CONTAI~1/MASTER~1/MASTER~1.GCO 16236540
/CONTAI~1/MASTER~1/MASTER~2.GCO 9633713
/PARTS-~1/HEATED~1/REPRIN~1.GCO 1308244
/PARTS-~1/HEATED~1/PRUSA_~1.GCO 1666128
End file list
@rbm78bln
Copy link

Hey guys!

Any news on this issue?

I was trying with the current firmware 3.10.0-4481 on my MK3S and was also stumbling on this issue: M20 returns uppercase filesnames and M23, M30, and M32 work only with lowercase filenames.

To me it actually doesn't matter what IS the case, yet all commands should make use of the same case...

@gudnimg
Copy link
Collaborator

gudnimg commented Aug 19, 2021

It should be easy to convert the inputs for M23, M30, and M32 to lower case, thus any case would be supported but then there is no way to differeniate between two files with the same name but with different cases.

Regarding M20, I would expect to see the actual case on the file name in the same way as it is stored into memory. Whether it contains a capital letter, all upper case or all lower case. But if we do this I suppose we should maybe also make M23, M30 and M32 case sensitive? ( that is, the user must type the name exactly as listed by M20)

But converting anything the user inputs into lower case will atleast improve the situation? Anyone have thoughts on this?

@github-actions
Copy link

github-actions bot commented Sep 6, 2023

This issue has been flagged as stale because it has been open for 60 days with no activity. The issue will be closed in 7 days unless someone removes the "stale" label or adds a comment.

@github-actions
Copy link

This issue has been closed due to lack of recent activity.

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Sep 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants