Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Setting Goerli flag in YAML does not set network to Prater #11122

Closed
metanull-operator opened this issue Jul 27, 2022 · 9 comments
Closed

Setting Goerli flag in YAML does not set network to Prater #11122

metanull-operator opened this issue Jul 27, 2022 · 9 comments
Labels
Blocked Blocked by research or external factors UX cosmetic / user experience related

Comments

@metanull-operator
Copy link
Contributor

if ctx.Bool(PraterTestnet.Name) {

Running v2.1.4-rc.0 with Goerli flag set in YAML config file does not set chain for Prater network. Using Goerli flag on command line does work. An alias for Prater was created with issue #11605, but as best as I can tell the cli library doesn't check aliases when using ctx.Bool on the line referenced in the link above.

@metanull-operator
Copy link
Contributor Author

Now that I think about it, my previous comment doesn't make sense. Alias appears to still be checked when goerli used on command line. So, not clear to me why this doesn't work from YAML.

@terencechain
Copy link
Member

terencechain commented Jul 27, 2022

Now that I think about it, my previous comment doesn't make sense. Alias appears to still be checked when goerli used on command line. So, not clear to me why this doesn't work from YAML.

Can you share the yaml file? and the cli command line to launch?

@metanull-operator
Copy link
Contributor Author

metanull-operator commented Jul 27, 2022

Unfortunately, I can no longer match up what my configuration was when I submitted this with the log entry I have that says I was on the wrong network.

Current logs seem to be about something different than my original report, but something doesn't seem right. I won't speculate further.

Systemd Service File:

`ExecStart=/home/prysm-beacon/bin/beacon-chain --config-file /home/prysm-beacon/prysm-beacon.yaml`

prysm-beacon.yaml

datadir: "/home/prysm-beacon/prysm"
p2p-host-ip: "XXX.XXX.XXX.XXX"
http-web3provider: "http://127.0.0.1:8545"
monitoring-host: "0.0.0.0"
p2p-tcp-port: XXXX
p2p-udp-port: XXXX
accept-terms-of-use: true
goerli: true
jwt-secret: "/srv/ethereum/secrets/jwtsecret"
genesis-state: "/home/prysm-beacon/prater/genesis.ssz"
#checkpoint-sync-url: "https://XXXXXXXXXX@eth2-beacon-prater.infura.io"
grpc-gateway-host: "0.0.0.0"
suggested-fee-recipient: "0xXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXX"

Logs

Jul 27 12:32:04 nuc systemd[1]: Started Prysm Beacon Chain Client.
Jul 27 12:32:04 nuc beacon-chain[143357]: time="2022-07-27 12:32:04" level=warning msg="Running on Ethereum Mainnet" prefix=flags
Jul 27 12:32:04 nuc beacon-chain[143357]: time="2022-07-27 12:32:04" level=info msg="Checking DB" database-path="/home/prysm-beacon/prysm/beaconchaindata" prefix=node
Jul 27 12:32:04 nuc beacon-chain[143357]: time="2022-07-27 12:32:04" level=info msg="Opening Bolt DB at /home/prysm-beacon/prysm/beaconchaindata/beaconchain.db" prefix=db
Jul 27 12:32:04 nuc beacon-chain[143357]: time="2022-07-27 12:32:04" level=error msg="you have disabled the flag enable-only-blinded-beacon-blocks, and your node must resync to ensure your database is compatible. If you do not want to resync, please re-enable the enable-only-blinded-beacon-blocks flag" prefix=main
Jul 27 12:32:04 nuc systemd[1]: prysm-beacon.service: Succeeded.
Jul 27 12:32:09 nuc systemd[1]: prysm-beacon.service: Scheduled restart job, restart counter is at 1.
Jul 27 12:32:09 nuc systemd[1]: Stopped Prysm Beacon Chain Client.
Jul 27 12:32:09 nuc systemd[1]: Started Prysm Beacon Chain Client.

After I remove goerli: true from config and add --goerli to systemd service file, I end up with this...

ExecStart=/home/prysm-beacon/bin/beacon-chain --config-file /home/prysm-beacon/prysm-beacon.yaml --goerli

Config

datadir: "/home/prysm-beacon/prysm"
p2p-host-ip: "XXX.XXX.XXX.XXX"
http-web3provider: "http://127.0.0.1:8545"
monitoring-host: "0.0.0.0"
p2p-tcp-port: XXXX
p2p-udp-port: XXXX
accept-terms-of-use: true
#goerli: true
jwt-secret: "/srv/ethereum/secrets/jwtsecret"
genesis-state: "/home/prysm-beacon/prater/genesis.ssz"
#checkpoint-sync-url: "https://XXXXXXXXXX@eth2-beacon-prater.infura.io"
grpc-gateway-host: "0.0.0.0"
suggested-fee-recipient: "0xXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXX"

Logs:

Jul 27 12:37:31 nuc systemd[1]: Started Prysm Beacon Chain Client.
Jul 27 12:37:31 nuc beacon-chain[144774]: time="2022-07-27 12:37:31" level=warning msg="Running on the Prater Testnet" prefix=flags

...and functioning resumes as normal. No problems syncing up.

Edit: Fixed some typos after I copied and pasted ExecStart.

@metanull-operator
Copy link
Contributor Author

You can see in the first log where is says it is connecting to mainnet. This is what made me initially think it wasn't respecting the Goerli flag in YAML. But from command line it says Prater.

@nisdas
Copy link
Member

nisdas commented Jul 28, 2022

we do versioning by the fork-version afaik, @kasey can confirm on this.

@metanull-operator
Copy link
Contributor Author

Sorry @nisdas, is your comment something actionable for me, or is this a note to devs?

@nisdas
Copy link
Member

nisdas commented Aug 4, 2022

Hey @metanull-operator , this is mostly a note to kasey

@james-prysm
Copy link
Contributor

urfave/cli#1394 looks like this is the underlying issue to this.

@james-prysm
Copy link
Contributor

I believe this will be fixed with v3 cli, waiting for release, I fixed the bug in the library.

@james-prysm james-prysm added Blocked Blocked by research or external factors UX cosmetic / user experience related labels Nov 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Blocked Blocked by research or external factors UX cosmetic / user experience related
Projects
None yet
Development

No branches or pull requests

5 participants