Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bazel 6 #11799

Closed
prestonvanloon opened this issue Dec 19, 2022 · 2 comments
Closed

Bazel 6 #11799

prestonvanloon opened this issue Dec 19, 2022 · 2 comments
Labels
Help Wanted Extra attention is needed

Comments

@prestonvanloon
Copy link
Member

💎 Issue

Background

Bazel 6 was released today and it has some breaking changes for the version of bazel_toolchains we are using.

Description

We need to update bazel_toolchains to the latest version which requires some updates to how we generate the cross-compile remote backend execution targets.

See: https://github.com/bazelbuild/bazel-toolchains#where-is-rbe_autoconfig
See: https://github.com/prysmaticlabs/prysm/blob/ce125b763c6f0ced1e9207e157be2f53e44fcb27/tools/cross-toolchain/README.md
See: #2849 (previous implementation of cross compile)

Step 1: Update .bazel_version to 6.0.0. (Use bazelisk to automatically download bazel 6 based on .bazel_version)
Step 2: Observe failing builds
Step 3: Update bazel-toolchains, fix everything (???), and update documentation for cross-toolchain compilation in docker sandbox or RBE with compatible backend
Step 4: Observe successful builds

@prestonvanloon prestonvanloon added the Help Wanted Extra attention is needed label Dec 19, 2022
@MohammadAbuzar945
Copy link

Update the .bazel_version file in your project to specify version 6.0.0. This will cause bazelisk, a tool that manages multiple versions of Bazel, to download and use Bazel 6 when you run Bazel commands.

Observe the builds in your project to see if they are failing. You may see errors or other issues that are caused by the breaking changes in Bazel 6.

Update bazel_toolchains to the latest version and make any necessary changes to your project's configuration or code to fix any issues caused by the update. You may also need to update the documentation for your project to reflect the changes made in step 3.

Observe the builds in your project again to see if they are successful. If the builds are successful, your project should be updated and ready to use with Bazel 6.

Keep in mind that updating to a new version of Bazel may introduce other changes or breaking changes that could affect your project. Be sure to carefully review the release notes for Bazel 6 and test your project thoroughly after updating to ensure that it is working as expected.

@nisdas
Copy link
Member

nisdas commented Jul 25, 2023

We are currently running 6.2.1 in develop , so this issue is resolved.

@nisdas nisdas closed this as completed Jul 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Help Wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

3 participants