Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate boltdb to bbolt #5186

Closed
prestonvanloon opened this issue Mar 24, 2020 · 2 comments · Fixed by #5193
Closed

Migrate boltdb to bbolt #5186

prestonvanloon opened this issue Mar 24, 2020 · 2 comments · Fixed by #5193
Labels
Enhancement New feature or request

Comments

@prestonvanloon
Copy link
Member

BoltDB is deprecated and we've hit our first issue after upgrading to go 1.14. As time goes on, more of these issues will appear so we should migrate to an alternative as soon as possible.

etcd maintains a fork of bbolt which has the fix for go 1.14 above.
https://github.com/etcd-io/bbolt

Specific fix etcd-io/bbolt#201

This should be a drop in replacement for boltdb.

@prestonvanloon prestonvanloon added the Enhancement New feature or request label Mar 24, 2020
@nisdas
Copy link
Member

nisdas commented Mar 24, 2020

This can be a drop in replacement but we might need to fork our metrics collector as it only supports the original boltdb. At least that was the blocker the last time I tried using the etcd fork

@prestonvanloon
Copy link
Member Author

Good point. We can fork the metrics collector and drop in bbolt there as well.

@prestonvanloon prestonvanloon linked a pull request Mar 24, 2020 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants