Pending validator count reflects partially deposited validators

[prestonvanloon]

🐞 Bug Report

Description

There seem to be validators which have sent the minimum deposit value (1 ETH). These validators are not eligible for activation and are in a "pending" state. Typically, the "pending" state is understood as being in queue for activation. As such, this UX is causing some confusion for users trying to understand the queue size and their position in queue.

Prometheus report

Etherscan

[0xKiwi]

How should we go about this? This appears to be a gap in our determination of validator status.

[prestonvanloon]

We will need another status value.

Here are the statuses we have at the moment:

enum ValidatorStatus {
  UNKNOWN_STATUS = 0;
  DEPOSITED = 1;
  PENDING = 2;
  ACTIVE = 3;
  EXITING = 4;
  SLASHING = 5;
  EXITED = 6;
}

To fix this, we can add a new enum value and clarify PENDING with a more strict definition.

• PENDING -- The validator is fully deposited and in the activation queue.
• PARTIALLY_DEPOSITED -- The validator has not met the deposit threshold.

[michaelhly]

I can work on this. We just need to check for deposit amount < 32 ETH (in wei) here:

prysm/beacon-chain/rpc/validator/status.go

Line 157 in 11c9699

case ethpb.ValidatorStatus_UNKNOWN_STATUS:

and return the PARTIALLY_DEPOSITEDstatus right?

[rauljordan]

@michaelhly what's the status on this one, how can we help?

[michaelhly]

@rauljordan Sorry, was a bit busy this week. Let me publish my PR. Just need to write tests.