QSP-16 Fix Support for IPv6 #6363
Conversation
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 7 days if no further activity occurs. Thank you for your contributions. |
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 7 days if no further activity occurs. Thank you for your contributions. |
|
This pull request has been closed due to inactivity. Please reopen this pull request if you would like to continue working on it. |
prestonvanloon
removed
the
Stale
Codecov Report
@@ Coverage Diff @@
## master #6363 +/- ##
=======================================
Coverage 61.90% 61.90%
=======================================
Files 411 411
Lines 33060 33060
=======================================
Hits 20466 20466
Misses 9695 9695
Partials 2899 2899 |
|
|
||
| // ExternalIPv6 retrieves any allocated IPv6 addresses | ||
| // from the accessible network interfaces. | ||
| func ExternalIPv6() (string, error) { |
There was a problem hiding this comment.
I realized ExternalIPv6() is not covered in external_ip_test.go . Should we cover it?
There was a problem hiding this comment.
The issue would be in bazels sandbox the ipv6 address isnt availble from the accessible network interface which makes it hard to test something like this.
What type of PR is this?
Bug Fix Raised from Audit
What does this PR do? Why is it needed?
an external ENR in
convertToSingleMultiAddr().Which issues(s) does this PR fix?
Part of #6327
Other notes for review