Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shift Sync Warn and Error Messages To Debug #7059

Merged
merged 2 commits into from
Aug 20, 2020
Merged

Shift Sync Warn and Error Messages To Debug #7059

merged 2 commits into from
Aug 20, 2020

Conversation

nisdas
Copy link
Member

@nisdas nisdas commented Aug 20, 2020

What type of PR is this?

Log Improvement

What does this PR do? Why is it needed?

To reduce confusion for node runners, this shifts all these logs to debug. As they can be very noisy and confusing
if you have a large number of peers.

Which issues(s) does this PR fix?

N.A

Other notes for review

@nisdas nisdas requested a review from a team as a code owner August 20, 2020 01:56
@codecov
Copy link

codecov bot commented Aug 20, 2020

Codecov Report

Merging #7059 into master will decrease coverage by 0.19%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##           master    #7059      +/-   ##
==========================================
- Coverage   62.41%   62.22%   -0.20%     
==========================================
  Files         402      401       -1     
  Lines       31895    31382     -513     
==========================================
- Hits        19907    19527     -380     
+ Misses       9185     9084     -101     
+ Partials     2803     2771      -32     

@nisdas nisdas merged commit ba5da21 into master Aug 20, 2020
@nisdas nisdas deleted the shiftToDebug branch August 20, 2020 03:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants