Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Slasher improvements #7061

Merged
merged 5 commits into from
Aug 20, 2020
Merged

Slasher improvements #7061

merged 5 commits into from
Aug 20, 2020

Conversation

shayzluf
Copy link
Contributor

@shayzluf shayzluf commented Aug 20, 2020

What type of PR is this?

Bug fix

What does this PR do? Why is it needed?
this pr fixes:

  • reconnect open files issue
  • add log for rpc server calls
  • sets spans-cache-size to 1500 by default
  • remove traces to improve performance

@shayzluf shayzluf requested a review from a team as a code owner August 20, 2020 04:57
slasher/rpc/server.go Outdated Show resolved Hide resolved
slasher/rpc/server.go Outdated Show resolved Hide resolved
slasher/rpc/server.go Outdated Show resolved Hide resolved
slasher/beaconclient/receivers.go Outdated Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Aug 20, 2020

Codecov Report

Merging #7061 into master will decrease coverage by 0.15%.
The diff coverage is 24.24%.

@@            Coverage Diff             @@
##           master    #7061      +/-   ##
==========================================
- Coverage   62.41%   62.26%   -0.16%     
==========================================
  Files         402      401       -1     
  Lines       31937    31385     -552     
==========================================
- Hits        19935    19543     -392     
+ Misses       9191     9075     -116     
+ Partials     2811     2767      -44     

@shayzluf shayzluf requested a review from 0xKiwi August 20, 2020 06:50
@shayzluf shayzluf self-assigned this Aug 20, 2020
@shayzluf shayzluf merged commit 2bf1332 into master Aug 20, 2020
@farazdagi farazdagi deleted the slasher_improvements branch August 21, 2020 10:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants