Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UnaggregatedAttestations use helper hasSeenBit #7083

Merged
merged 3 commits into from
Aug 22, 2020
Merged

Conversation

terencechain
Copy link
Member

What type of PR is this?

Feature

What does this PR do? Why is it needed?
This PR updates UnaggregatedAttestations to use helper hasSeenBit

@codecov
Copy link

codecov bot commented Aug 22, 2020

Codecov Report

Merging #7083 into master will decrease coverage by 0.20%.
The diff coverage is 62.50%.

@@            Coverage Diff             @@
##           master    #7083      +/-   ##
==========================================
- Coverage   62.46%   62.26%   -0.21%     
==========================================
  Files         407      406       -1     
  Lines       31875    31597     -278     
==========================================
- Hits        19912    19674     -238     
+ Misses       9160     9127      -33     
+ Partials     2803     2796       -7     

Copy link
Contributor

@farazdagi farazdagi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just that unnecessary blank line needs removal.

beacon-chain/blockchain/chain_info_test.go Outdated Show resolved Hide resolved
Co-authored-by: Victor Farazdagi <simple.square@gmail.com>
Copy link
Contributor

@farazdagi farazdagi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thank you!

@terencechain terencechain merged commit 5977343 into master Aug 22, 2020
@delete-merged-branch delete-merged-branch bot deleted the use-seen branch August 22, 2020 20:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants