Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Default Prylabs ETH1 Endpoint #7120

Merged
merged 3 commits into from
Aug 27, 2020
Merged

Remove Default Prylabs ETH1 Endpoint #7120

merged 3 commits into from
Aug 27, 2020

Conversation

nisdas
Copy link
Member

@nisdas nisdas commented Aug 27, 2020

What type of PR is this?

Feature Addition

What does this PR do? Why is it needed?

  • Removes the default eth1 endpoint which is hosted by Prysmatic Labs.
  • Change error message to state consequences of not running your own eth1 node.

Which issues(s) does this PR fix?

Fixes #6884

Other notes for review

@nisdas nisdas requested a review from a team as a code owner August 27, 2020 06:33
@codecov
Copy link

codecov bot commented Aug 27, 2020

Codecov Report

Merging #7120 into master will increase coverage by 1.64%.
The diff coverage is 70.96%.

@@            Coverage Diff             @@
##           master    #7120      +/-   ##
==========================================
+ Coverage   60.07%   61.71%   +1.64%     
==========================================
  Files         323      408      +85     
  Lines       27422    32152    +4730     
==========================================
+ Hits        16473    19842    +3369     
- Misses       8733     9485     +752     
- Partials     2216     2825     +609     

Copy link
Member

@terencechain terencechain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good.

Can you also update the doc or add an issue for updating the doc to reflect this change? (If we need to) https://github.com/prysmaticlabs/documentation

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

FR: Phase out hosted eth1 support
4 participants