Replace context.Background() with more appropriate context #7136
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: terence tsao <terence@prysmaticlabs.com>
nisdas
previously approved these changes
Aug 29, 2020
rauljordan
previously approved these changes
Aug 31, 2020
rauljordan
previously approved these changes
Sep 1, 2020
rauljordan
previously approved these changes
Sep 1, 2020
|
@prestonvanloon still have conflicts |
farazdagi
approved these changes
Sep 9, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Other
What does this PR do? Why is it needed?
As title describes, this PR replaces misused context.Background() with an appropriate parent context.
Which issues(s) does this PR fix?
Other notes for review
There are a few that I replaced with context.TODO(). I felt that these would require more substantial refactoring that is beyond the original intent of this PR.