Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle Saved Genesis Interop States #7146

Merged
merged 5 commits into from
Aug 31, 2020
Merged

Conversation

nisdas
Copy link
Member

@nisdas nisdas commented Aug 31, 2020

What type of PR is this?

Bug Fix

What does this PR do? Why is it needed?

In #7120, we disabled our default eth1 node from being used by the node and #7126 as a follow up
crashed nodes if they were not chainstarted and had no attached eth1 node. This however broke
the workflow for our nodes running through interop, this PR adds corrections to ensure that interop
nodes run too.

  • Check for genesis state too, so that interop nodes are able to proceed.
  • Add basic unit tests for this change.

Which issues(s) does this PR fix?

N.A

Other notes for review

@nisdas nisdas requested a review from a team as a code owner August 31, 2020 06:44
@nisdas nisdas requested review from farazdagi, 0xKiwi and rkapka August 31, 2020 06:44
@prylabs-bulldozer prylabs-bulldozer bot merged commit 3ed7b23 into master Aug 31, 2020
@delete-merged-branch delete-merged-branch bot deleted the handleInteropCase branch August 31, 2020 13:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants