Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Slasher doesnt handle attestation edge case well #7161

Closed
shayzluf opened this issue Sep 2, 2020 · 1 comment · Fixed by #7839
Closed

Slasher doesnt handle attestation edge case well #7161

shayzluf opened this issue Sep 2, 2020 · 1 comment · Fixed by #7839
Assignees
@shayzluf
Milestone
Diamond

Comments

@shayzluf
Copy link
Contributor

shayzluf commented Sep 2, 2020 •
edited by nisdas
Loading

🐞 Bug Report

Description

Slasher doesn't handle unexpected cases like source > target well. Underflow, then ignored, while still potentially slashable.
@shayzluf shayzluf self-assigned this Sep 2, 2020
@nisdas nisdas changed the title Salsher doesnt handle attestation edge case well Slasher doesnt handle attestation edge case well Sep 3, 2020
@rauljordan rauljordan mentioned this issue Oct 26, 2020
Closed
@rauljordan rauljordan added this to the Diamond milestone Nov 3, 2020
@shayzluf
Copy link
Contributor Author

working on it

@shayzluf shayzluf mentioned this issue Nov 17, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@shayzluf shayzluf

Labels
None yet
Projects
None yet
Milestone
Diamond
Development

Successfully merging a pull request may close this issue.

Source lrg target prysmaticlabs/prysm
2 participants
@rauljordan @shayzluf