Safer validator protection db dir #7176
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…bs/prysm into move_validator_protection_db
…idator_protection_db
Codecov Report
@@ Coverage Diff @@
## master #7176 +/- ##
==========================================
+ Coverage 60.07% 61.77% +1.70%
==========================================
Files 323 410 +87
Lines 27422 32678 +5256
==========================================
+ Hits 16473 20188 +3715
- Misses 8733 9613 +880
- Partials 2216 2877 +661 |
|
@rauljordan not sure how to handle web client dir location and wether to put the db in accounts dir. wdyt? |
rauljordan
reviewed
Sep 8, 2020
rauljordan
approved these changes
Sep 8, 2020
farazdagi
added a commit
that referenced
this pull request
Sep 8, 2020
prylabs-bulldozer bot
pushed a commit
that referenced
this pull request
Sep 8, 2020
* fix resource leak * fixes leak in blocks fetcher * client/validator release ticker resorces * powchain, more straightforward ticker closing * adds missing ticker.stop() calls * more straightforward ticker closing * Merge refs/heads/master into fix-unclosed-tickers-timers * Merge refs/heads/master into fix-unclosed-tickers-timers * Merge refs/heads/master into fix-unclosed-tickers-timers * gofmt issues introduced in #7176
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Feature
What does this PR do? Why is it needed?
On the path to harden slashing protection this pr intends to move the vary sensitive local protection db to am allready sensitive directory which users allready take care not to erase
Which issues(s) does this PR fix?
Part of #6948