Add and verify weak-subjectivity-checkpoint flag
#7256
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #7256 +/- ##
==========================================
+ Coverage 60.07% 61.62% +1.54%
==========================================
Files 323 418 +95
Lines 27422 33111 +5689
==========================================
+ Hits 16473 20403 +3930
- Misses 8733 9777 +1044
- Partials 2216 2931 +715 |
rauljordan
reviewed
Sep 16, 2020
| } | ||
|
|
||
| // Get the epoch number from input string. | ||
| epoch, err := strconv.ParseUint(s[1], 10, 64) |
There was a problem hiding this comment.
Good point. I'll add a check
nisdas
reviewed
Sep 17, 2020
| }, | ||
| { | ||
| name: "Correct input #1", | ||
| input: "0x010203:987", |
There was a problem hiding this comment.
shouldnt the block root be 32 bytes. Lets add a check for it.
rauljordan
reviewed
Sep 17, 2020
| s := strings.Split(wsp, ":") | ||
| if len(s) != 2 { | ||
| return nil, 0, errors.New("bad format string") | ||
| } |
There was a problem hiding this comment.
Maybe output why it is not well formatted, showing them the expected format. Perhaps that should also be part of the flag usage if not specified already
There was a problem hiding this comment.
it's part of the flag usage. I'll reiterate in the error again
rauljordan
approved these changes
Sep 17, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
What does this PR do? Why is it needed?
This PR implemented a CLI flag to take in weak subjectivity checkpoint. As discussed with teams and in the reference (below). The CLI input is in
block_root:epoch_numberformat, whereblock_rootis the root of a block atepoch_numberis the epoch of the block.It also added a helper to validate and parse the input string + tests to go with it. The results are inserted to initial sync service struct but not used at the moment. It will be used in the subsequent PRs
Reference: https://github.com/ethereum/eth2.0-specs/blob/weak-subjectivity-guide/specs/phase0/weak-subjectivity.md#weak-subjectivity-sync-procedure