Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disables resync when init-sync is disabled #7259

Merged
merged 1 commit into from
Sep 17, 2020

Conversation

farazdagi
Copy link
Contributor

What type of PR is this?

Other

What does this PR do? Why is it needed?

  • Follow-up to Add Flag To Disable Initial Sync #7258
  • Without this change, client will be pushed to init-sync via resync (happens when one is 2 epochs behind the majority of the peers). This PR makes sure that resync goroutine is never started.

Which issues(s) does this PR fix?

N/A

Other notes for review

@farazdagi farazdagi requested a review from a team as a code owner September 17, 2020 11:20
@farazdagi farazdagi self-assigned this Sep 17, 2020
@codecov
Copy link

codecov bot commented Sep 17, 2020

Codecov Report

Merging #7259 into master will decrease coverage by 0.05%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #7259      +/-   ##
==========================================
- Coverage   61.67%   61.61%   -0.06%     
==========================================
  Files         417      417              
  Lines       33136    33109      -27     
==========================================
- Hits        20436    20400      -36     
- Misses       9768     9782      +14     
+ Partials     2932     2927       -5     

@prylabs-bulldozer prylabs-bulldozer bot merged commit 76bac74 into master Sep 17, 2020
@delete-merged-branch delete-merged-branch bot deleted the no-resync-when-init-sync-disabled branch September 17, 2020 11:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants