Store Hashed Password to Wallet Path #7295
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…m into fix-password-override
rauljordan
requested review from
prestonvanloon,
rkapka,
shayzluf and
farazdagi
prestonvanloon
approved these changes
Sep 22, 2020
Codecov Report
@@ Coverage Diff @@
## master #7295 +/- ##
==========================================
- Coverage 59.55% 59.36% -0.19%
==========================================
Files 419 418 -1
Lines 30185 30062 -123
==========================================
- Hits 17976 17847 -129
- Misses 9265 9281 +16
+ Partials 2944 2934 -10 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
What does this PR do? Why is it needed?
This PR stores the wallet password's bcrypt hash to the wallet path upon wallet creation, wallet recovery, or wallet import. This hash will be checked every time we attempt to open the wallet. If a user does not have this hash stored on disk, we attempt to initialize the keymanager (which will perform some validation by attempting to decrypt the account keystores), and then write the password hash to disk for next time, allowing this change to be backwards compatible.
Which issues(s) does this PR fix?
Fixes #7269