-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor head info for better usages for lock #7432
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tests fail here |
Codecov Report
@@ Coverage Diff @@
## master #7432 +/- ##
=======================================
Coverage 60.17% 60.17%
=======================================
Files 424 424
Lines 30451 30451
=======================================
Hits 18323 18323
Misses 9129 9129
Partials 2999 2999 |
#7429 was accepted w/o checks (probably because of updates to our cluster?). Anyway, |
farazdagi
approved these changes
Oct 6, 2020
Issue seems to be more involved (needs mod tidy as well) -- fixing it in #7446 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor
chain_info.go
andhead.go
for better lock usages. This follows @farazdagi 's suggestion to apply lock to exported getters and remove lock for internal getters. This eliminated discrepancies where a getter could be missing lock or even dead lock