Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor head info for better usages for lock #7432

Merged
merged 9 commits into from
Oct 6, 2020
Merged

Conversation

terencechain
Copy link
Member

@terencechain terencechain commented Oct 4, 2020

Refactor chain_info.go and head.go for better lock usages. This follows @farazdagi 's suggestion to apply lock to exported getters and remove lock for internal getters. This eliminated discrepancies where a getter could be missing lock or even dead lock

@terencechain terencechain self-assigned this Oct 4, 2020
@terencechain terencechain marked this pull request as ready for review October 4, 2020 22:54
@terencechain terencechain requested a review from a team as a code owner October 4, 2020 22:54
@nisdas
Copy link
Member

nisdas commented Oct 5, 2020

Tests fail here

@codecov
Copy link

codecov bot commented Oct 6, 2020

Codecov Report

Merging #7432 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #7432   +/-   ##
=======================================
  Coverage   60.17%   60.17%           
=======================================
  Files         424      424           
  Lines       30451    30451           
=======================================
  Hits        18323    18323           
  Misses       9129     9129           
  Partials     2999     2999           

@farazdagi
Copy link
Contributor

#7429 was accepted w/o checks (probably because of updates to our cluster?). Anyway, go fmt is needed (will push the update now).

@farazdagi
Copy link
Contributor

Issue seems to be more involved (needs mod tidy as well) -- fixing it in #7446

@prylabs-bulldozer prylabs-bulldozer bot merged commit c0ed43d into master Oct 6, 2020
@delete-merged-branch delete-merged-branch bot deleted the better-locks branch October 6, 2020 10:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants