Register Subscribers After Node Is Synced #7468
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
farazdagi
reviewed
Oct 8, 2020
beacon-chain/sync/service.go
Outdated
Comment on lines
269
to
270
| // Exit once we received the synced event. | ||
| stateSub.Unsubscribe() |
There was a problem hiding this comment.
When you return, deferred stateSub.Unsubscribe() will be called.
I guess there is double unsubscribe in the original implementation as well?
|
Nishant, per your request to pre-review: except for that double unsubscribe (which, I guess, is a no-op, on the second invocation) everything looks solid. |
farazdagi
approved these changes
Oct 9, 2020
Codecov Report
@@ Coverage Diff @@
## master #7468 +/- ##
=======================================
Coverage 60.65% 60.65%
=======================================
Files 426 426
Lines 30384 30384
=======================================
Hits 18430 18430
Misses 8954 8954
Partials 3000 3000 |
prestonvanloon
requested changes
Oct 9, 2020
| } | ||
| log.WithField("starttime", startTime).Debug("Chain started in sync service") | ||
| s.chainStarted = true | ||
| }() |
There was a problem hiding this comment.
Do you need to return after this go routine? Otherwise it's still in the for loop, right?
There was a problem hiding this comment.
We need it to continue looping as we also need to receive the synced event before
exiting.
prestonvanloon
approved these changes
Oct 10, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Feature Addition
What does this PR do? Why is it needed?
As part of #6622 , we will need to enable gossip scoring. However gossip peer scoring relies on unsynced nodes staying out
of the mesh until they are synced. This PR registers the relevant subscribers later, and only joins the mesh for the relevant topics after the node is synced.
Which issues(s) does this PR fix?
N.A
Other notes for review