Move IsCanonical implementation to forkchoice package #7602
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #7602 +/- ##
==========================================
+ Coverage 62.11% 62.23% +0.12%
==========================================
Files 422 422
Lines 30015 30136 +121
==========================================
+ Hits 18644 18756 +112
- Misses 8428 8431 +3
- Partials 2943 2949 +6 |
prestonvanloon
approved these changes
Oct 23, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Canonical blocks mapping was updated and maintained in
blockchainpkg, but canonical calculation was updated inforkchoicepkg. This is a disparity and as a result more cpu compute got used due to duplication efforts.This PR moves the update and maintenance of canonical mapping to
forkchoicepkg. As a result less compute compute gets used due to more cleanly updates.Before:
After:
