Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Final Pass at Removing Deprecated Flags and Old Testnet Configs for v1.0.0 #7798

Closed
rauljordan opened this issue Nov 12, 2020 · 7 comments
Closed
Assignees
Labels
Cleanup Code health!
Milestone

Comments

@rauljordan
Copy link
Contributor

This is a tracking issue to remove all deprecated and old testnet configs and flags for Prysm's v1.0.0 release, to start mainnet with a clean slate

@rauljordan rauljordan added the Cleanup Code health! label Nov 12, 2020
@rauljordan rauljordan added this to the Diamond milestone Nov 12, 2020
@shayzluf
Copy link
Contributor

@rauljordan can we bring back :

@terencechain
Copy link
Member

@rauljordan can we bring back :

@shayzluf can you please clarify why they are needed? Lighthouse or teku for example do not have those flags

@nisdas
Copy link
Member

nisdas commented Nov 17, 2020

#7836 has been merged again. So you can just use that

@shayzluf
Copy link
Contributor

@terencechain for disable-broadcast-slashings i think people would like to try their luck in including the slashings they found

@terencechain
Copy link
Member

@terencechain for disable-broadcast-slashings i think people would like to try their luck in including the slashings they found

I dont think we should encourage this behavior:
1.) Not outlined in the validator spec
2.) Other clients (LH and Teku) dont have this
3.) We dont have documentation to support this
4.) Incentives don't add up, the inclusion reward is little and chances to become proposer is also very little
5.) It was fine to implement for experimental and testing purpose but im not sure how we feel about rolling this feature into mainnet

@prestonvanloon
Copy link
Member

The only remaining items for this are just to remove deprecated flags? @rauljordan

@terencechain
Copy link
Member

Fixed with #7877

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Cleanup Code health!
Projects
None yet
Development

No branches or pull requests

5 participants