Cancel node context after StopAll #8289
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rkapka
changed the title
rkapka
commented
Jan 19, 2021
slasher/node/node.go
Outdated
| @@ -150,11 +150,11 @@ func (s *SlasherNode) Close() { | |||
| defer s.lock.Unlock() | |||
|
|
|||
| log.Info("Stopping hash slinging slasher") | |||
| s.cancel() | |||
There was a problem hiding this comment.
The same bug-prone code as in the beacon node - cancelling the parent context before StopAll is called.
Codecov Report
@@ Coverage Diff @@
## develop #8289 +/- ##
==========================================
Coverage ? 57.12%
==========================================
Files ? 449
Lines ? 31524
Branches ? 0
==========================================
Hits ? 18007
Misses ? 10719
Partials ? 2798 |
rauljordan
previously approved these changes
Jan 20, 2021
|
Conflict and tests failing |
prestonvanloon
previously approved these changes
Jan 21, 2021
rkapka
dismissed stale reviews from prestonvanloon and rauljordan
via
3dc942b
It's the duplicate wallet import test that is failing. It's causing problems in all of our PRs. |
I had not implemented this for validator because the struct did not contain |
rauljordan
approved these changes
Jan 25, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Other
What does this PR do? Why is it needed?
#7625 removed context cancelling from the beacon node because it caused a panic - cancelling the parent context before
StopAll, during which services are being shut down, caused child contexts inside these services to be cancelled before services had a chance to clean themselves up.Last week me and @prestonvanloon discussed some related issue and it occurred to us that it's safe to cancel the parent context after all child contexts have already done their job, i.e. after
StopAll. This PR adopts this solution.Which issues(s) does this PR fix?
N/A
Other notes for review
So simple yet so clever.