ETH2 Types: Epoch #8373
ETH2 Types: Epoch #8373
Conversation
😱prysm/endtoend/helpers/epochTimer.go Line 55 in f9303ca |
That's a misnomer, what is there is actually a slot number (I've that as |
| @@ -115,6 +117,12 @@ func deepValueEqual(v1, v2 reflect.Value, visited map[visit]bool, depth int) boo | |||
| } | |||
| return true | |||
| case reflect.Uint64: | |||
| switch v1.Type().Name() { | |||
| case "Epoch": | |||
| return v1.Interface().(types.Epoch) == v2.Interface().(types.Epoch) | |||
There was a problem hiding this comment.
For deep value assertions to work shouldn't uint64 and types.Epoch be equal ? This makes it only equal if they are of types.Epoch
There was a problem hiding this comment.
Well, if we are comparing epochs, both should be epochs, imo. While underlying type of Epoch is uint64, and their integral values are the same, I believe if sth is epoch, it should be typed correctly, or not be considered as equal.
There was a problem hiding this comment.
Fair enough, the deep equal is only used in our pending queue while comparing the same type, so not a big issue. Its fine in that case.
|
Note: Per Nishant's request will sync from genesis and run some validators on top of this branch. If everything works, will merge this PR. |
farazdagi
dismissed stale reviews from rauljordan and terencechain
via
a24c3b4
Codecov Report
@@ Coverage Diff @@
## develop #8373 +/- ##
==========================================
Coverage ? 58.03%
==========================================
Files ? 454
Lines ? 32212
Branches ? 0
==========================================
Hits ? 18695
Misses ? 10657
Partials ? 2860 |
What type of PR is this?
What does this PR do? Why is it needed?
types.Epoch.Which issues(s) does this PR fix?
Part of #8205
Other notes for review