Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ran code inspect for clean up #8387

Merged
merged 1 commit into from
Feb 3, 2021
Merged

Ran code inspect for clean up #8387

merged 1 commit into from
Feb 3, 2021

Conversation

terencechain
Copy link
Member

What type of PR is this?

Cleanup

What does this PR do? Why is it needed?

Ran goland code inspect for some cleanups. They are

  • Reports names starts with package name.
  • Generic receiver names
  • Sort import names

Which issues(s) does this PR fix?

N/A

Other notes for review

N/A

@terencechain terencechain requested a review from a team as a code owner February 3, 2021 02:03
@terencechain terencechain self-assigned this Feb 3, 2021
@rauljordan rauljordan merged commit 616081f into develop Feb 3, 2021
@delete-merged-branch delete-merged-branch bot deleted the code-inspect branch February 3, 2021 16:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rauljordan rauljordan rauljordan approved these changes

@rkapka rkapka Awaiting requested review from rkapka

@nisdas nisdas Awaiting requested review from nisdas

Assignees

@terencechain terencechain

Labels
Cleanup Code health!
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@terencechain @rauljordan