Provide TLS certificate to gRPC gateway #8418
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Bug fix
What does this PR do? Why is it needed?
gRPC gateway is effectively a gRPC client that connects to the beacon node. The gRPC gateway needs the TLS certificate if the beacon node is serving gRPC with TLS.
Which issues(s) does this PR fix?
Fixes #8414
Other notes for review
I had to generate an SSL cert with
subjectAltName = IP:127.0.0.1or gRPC client was complaining.Tested by accessing
http://127.0.0.1:3500/eth/v1alpha1/node/versionand:8080/healthzwithout issue.