Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Code inspect - clean ups #8445

Merged
merged 1 commit into from
Feb 12, 2021
Merged

Code inspect - clean ups #8445

merged 1 commit into from
Feb 12, 2021

Conversation

terencechain
Copy link
Member

What type of PR is this?

Code health

What does this PR do? Why is it needed?

Ran code inspect and fixed warnings revolving:

  • Variable name the same as package name
  • Conversion from int to string interprets integer value as code point

Which issues(s) does this PR fix?

N/A

Other notes for review

N/A

@terencechain terencechain self-assigned this Feb 12, 2021
@terencechain terencechain requested a review from a team as a code owner February 12, 2021 22:00
@rauljordan rauljordan merged commit 068f758 into develop Feb 12, 2021
@delete-merged-branch delete-merged-branch bot deleted the cleanups branch February 12, 2021 23:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rauljordan rauljordan rauljordan approved these changes

@shayzluf shayzluf Awaiting requested review from shayzluf

@prestonvanloon prestonvanloon Awaiting requested review from prestonvanloon

@rkapka rkapka Awaiting requested review from rkapka

Assignees

@terencechain terencechain

Labels
Cleanup Code health!
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@terencechain @rauljordan