Migration package tests #8524
Merged
Migration package tests #8524
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nisdas
reviewed
Feb 26, 2021
|
|
||
| // HydrateV1SignedBeaconBlock hydrates a signed beacon block with correct field length sizes | ||
| // to comply with fssz marshalling and unmarshalling rules. | ||
| func HydrateV1SignedBeaconBlock(b *v1.SignedBeaconBlock) *v1.SignedBeaconBlock { |
There was a problem hiding this comment.
Test for this? : )
TestHydrateSignedBeaconBlock_NoError for reference
Codecov Report
@@ Coverage Diff @@
## develop #8524 +/- ##
==========================================
Coverage ? 58.16%
==========================================
Files ? 460
Lines ? 33044
Branches ? 0
==========================================
Hits ? 19219
Misses ? 10905
Partials ? 2920 |
nisdas
approved these changes
Mar 1, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Testing
What does this PR do? Why is it needed?
The
migrationpackage, used for mapping between new and old proto objects, did not contain any tests. The PR addresses this repugnant state of affairs.Which issues(s) does this PR fix?
N/A
Other notes for review
N/A