Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create Bucket Only Once #8579

Merged
merged 2 commits into from
Mar 9, 2021
Merged

Create Bucket Only Once #8579

merged 2 commits into from
Mar 9, 2021

Conversation

nisdas
Copy link
Member

@nisdas nisdas commented Mar 9, 2021

What type of PR is this?

Method Cleanup

What does this PR do? Why is it needed?

  • Creates the buckets only once in each method call rather than for each pubkey.

Which issues(s) does this PR fix?

N.A

Other notes for review

@nisdas nisdas requested a review from a team as a code owner March 9, 2021 07:07
farazdagi
farazdagi approved these changes Mar 9, 2021
View reviewed changes
Copy link
Contributor

@farazdagi farazdagi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch!

@rauljordan rauljordan merged commit 2bb0a60 into develop Mar 9, 2021
@delete-merged-branch delete-merged-branch bot deleted the shiftBucketCreation branch March 9, 2021 14:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rauljordan rauljordan rauljordan approved these changes

@farazdagi farazdagi farazdagi approved these changes

@0xKiwi 0xKiwi Awaiting requested review from 0xKiwi

@prestonvanloon prestonvanloon Awaiting requested review from prestonvanloon

@terencechain terencechain Awaiting requested review from terencechain

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nisdas @farazdagi @rauljordan