Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes flaky TestBlocksFetcher_nonSkippedSlotAfter test #8586

Merged
merged 2 commits into from
Mar 10, 2021

Conversation

farazdagi
Copy link
Contributor

What type of PR is this?

Bug fix

What does this PR do? Why is it needed?

  • Since non-skipped slot is located using random sampling of future epochs, number of rounds in non-deterministic (normally 100 rounds cap is more than enough, but from time to time this is not enough -- and test fails).
  • Instead of counting rounds, 5 seconds time cap is used (normally, completes in less than a second, occasionally spiking to 2 seconds). I've run the test for 1000 rounds, several times (with previous code ~ 1 out of every 20 tests were failing, with new time cap -- no failures were produced, so we are more robust now).

Which issues(s) does this PR fix?

Fixes #8201

Other notes for review

@farazdagi farazdagi added this to the 1.3.x milestone Mar 10, 2021
@farazdagi farazdagi self-assigned this Mar 10, 2021
@farazdagi farazdagi requested a review from a team as a code owner March 10, 2021 15:07
@prylabs-bulldozer prylabs-bulldozer bot merged commit fa92766 into develop Mar 10, 2021
@delete-merged-branch delete-merged-branch bot deleted the fix-flaky-init-sync-test branch March 10, 2021 20:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve flaky init-sync test: TestBlocksFetcher_nonSkippedSlotAfter
2 participants