Add a separate unit test for ComputeDomainAndSign #8600
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
farazdagi
changed the title
Codecov Report
@@ Coverage Diff @@
## develop #8600 +/- ##
===========================================
- Coverage 61.18% 61.10% -0.08%
===========================================
Files 494 494
Lines 34363 34432 +69
===========================================
+ Hits 21024 21041 +17
- Misses 10195 10245 +50
- Partials 3144 3146 +2 |
terencechain
approved these changes
Mar 29, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
What does this PR do? Why is it needed?
beacon-chain/core/helperspackage by adding separate test case forComputeDomainAndSignfunction. Further updates tocore/helperstests are expected, but this PR is sitting for too long in drafts, so further work will be done in a scope of another PR.Which issues(s) does this PR fix?
N/A
Other notes for review