Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

State: various clean up #8633

Merged
merged 2 commits into from
Mar 19, 2021
Merged

State: various clean up #8633

merged 2 commits into from
Mar 19, 2021

Conversation

terencechain
Copy link
Member

What type of PR is this?

Cleanup

What does this PR do? Why is it needed?

Clean up state package:

  • rename /interface/interface.go for /interface/beacon_state_v0.go so we can have beacon_state_v1.go
  • fix stateV0's godoc package comment
  • fix IsNil's godoc function comment
  • move merkleizeTrieLeaves to stateutil pkg for reusability

Which issues(s) does this PR fix?

Fixes #

Other notes for review

@terencechain terencechain self-assigned this Mar 19, 2021
@terencechain terencechain requested a review from a team as a code owner March 19, 2021 17:42
@prylabs-bulldozer prylabs-bulldozer bot merged commit 9421ac1 into develop Mar 19, 2021
@delete-merged-branch delete-merged-branch bot deleted the state-cleanup branch March 19, 2021 20:03
@terencechain terencechain mentioned this pull request Mar 21, 2021
Closed
62 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rauljordan rauljordan rauljordan approved these changes

@0xKiwi 0xKiwi Awaiting requested review from 0xKiwi

@prestonvanloon prestonvanloon Awaiting requested review from prestonvanloon

Assignees

@terencechain terencechain

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@terencechain @rauljordan