Embed Config Pattern For Attestation, POW Chain, and RPC Services #8635
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## develop #8635 +/- ##
===========================================
+ Coverage 61.35% 61.40% +0.05%
===========================================
Files 488 493 +5
Lines 34297 34692 +395
===========================================
+ Hits 21042 21304 +262
- Misses 10145 10247 +102
- Partials 3110 3141 +31 |
kevlu93
force-pushed
the
embed-config-pattern
branch
from
603f094 to
fde7570
Compare
|
Sorry should not have amended the previous commit with the formatting changes. |
terencechain
approved these changes
Mar 21, 2021
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Other
What does this PR do? Why is it needed?
This pull request refactors the Service struct for the Attestation, POW Chain, and RPC services by having a pointer to the Config struct as one of the fields, removing duplicated field declarations.
Which issues(s) does this PR fix?
Part of #8603
Other notes for review
See #8618