Fix Secrets Failing Build #8660
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
prestonvanloon
approved these changes
Mar 24, 2021
Codecov Report
@@ Coverage Diff @@
## develop #8660 +/- ##
===========================================
- Coverage 61.21% 61.20% -0.02%
===========================================
Files 493 494 +1
Lines 34296 34345 +49
===========================================
+ Hits 20996 21022 +26
- Misses 10169 10180 +11
- Partials 3131 3143 +12 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No tracking issue. We utilize DeepSource.io's secret analysis tool, but it has always been failing due to some files that are as intended. Two of these three failures were in an unused package we can safely remove. The other is in a test we can exclude.