Fix All Deep Source Shell Issues and Go Issues #8661
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
farazdagi
reviewed
Mar 24, 2021
| echo "Issue referenced has already been closed" >&2; | ||
| echo "Issue Number: $issueNum" >&2; | ||
| exit 1; | ||
| fi | ||
| done < <(grep -PrinH -o -h '(?<!context\.)todo\(#{0,1}\K(\d+)' --include \*.go *) | ||
| done < <(grep -PrinH -o -h '(?<!context\.)todo\(#{0,1}\K(\d+)' --include ./*.go) |
There was a problem hiding this comment.
Will this cover all go files (or should it be ./**/*.go instead)?
farazdagi
reviewed
Mar 24, 2021
| @@ -1,24 +1,23 @@ | |||
| #!/bin/bash | |||
|
|
|||
| # Continuous integration script to check that TODOs are in the correct format | |||
| OUTPUT="$(grep -PrinH '(?<!context\.)todo(?!\(#{0,1}\d+\))' --include \*.go --exclude *site_data.go --exclude *mainnet_config.go *)"; | |||
| OUTPUT="$(grep -PrinH '(?<!context\.)todo(?!\(#{0,1}\d+\))' --include ./**/*.go --exclude ./*site_data.go --exclude ./*mainnet_config.go)"; | |||
There was a problem hiding this comment.
Again, will ./*site_data.go match all those items that *site_data.go covers?
rauljordan
changed the title
farazdagi
approved these changes
Mar 24, 2021
Codecov Report
@@ Coverage Diff @@
## develop #8661 +/- ##
===========================================
+ Coverage 61.22% 61.24% +0.02%
===========================================
Files 494 494
Lines 34345 34343 -2
===========================================
+ Hits 21027 21035 +8
+ Misses 10177 10170 -7
+ Partials 3141 3138 -3 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR resolves all pending deep source issues for shell scripts, which make all PRs that are targeting the non-default branch red