ProcessPreGenesisDeposits: Remove context.TODO() usage #8705
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rkapka
previously approved these changes
Apr 3, 2021
Codecov Report
@@ Coverage Diff @@
## develop #8705 +/- ##
===========================================
- Coverage 61.47% 61.41% -0.06%
===========================================
Files 499 499
Lines 34789 34791 +2
===========================================
- Hits 21386 21368 -18
- Misses 10230 10250 +20
Partials 3173 3173 |
farazdagi
previously approved these changes
Apr 4, 2021
farazdagi
approved these changes
Apr 4, 2021
rauljordan
approved these changes
Apr 5, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
What does this PR do? Why is it needed?
Not a fan of passing
context.TODO()toProcessPreGenesisDeposits. This fixes to use parent context