Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update processJustificationAndFinalization(), per current specs #8741

Merged

Conversation

farazdagi
Copy link
Contributor

What type of PR is this?

Other / Cleanup

What does this PR do? Why is it needed?

  • In the current specs the process_justification_and_finalization() has been updated, most of functions body was extracted into weigh_justification_and_finalization() (see Justification and Finalization)
  • This PR does the corresponding update to our code:
    • weighJustificationAndFinalization() function is introduced
    • ProcessJustificationAndFinalizationPreCompute() calls that newly introduced function.

Which issues(s) does this PR fix?

N/A

Other notes for review

  • No semantics changed, just refactoring of the code to match closer to the specs.

@farazdagi farazdagi requested a review from terencechain April 12, 2021 08:39
@farazdagi farazdagi self-assigned this Apr 12, 2021
@farazdagi farazdagi requested a review from a team as a code owner April 12, 2021 08:39
@codecov
Copy link

codecov bot commented Apr 12, 2021

Codecov Report

Merging #8741 (a82d28a) into develop (5217081) will decrease coverage by 15.71%.
The diff coverage is 77.77%.

@@             Coverage Diff              @@
##           develop    #8741       +/-   ##
============================================
- Coverage    61.51%   45.79%   -15.72%     
============================================
  Files          509      480       -29     
  Lines        34789    33390     -1399     
============================================
- Hits         21400    15291     -6109     
- Misses       10219    15535     +5316     
+ Partials      3170     2564      -606     

@nisdas nisdas added this to the v1.3.8 milestone Apr 12, 2021
Copy link
Member

@terencechain terencechain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@prylabs-bulldozer prylabs-bulldozer bot merged commit 5f3299e into develop Apr 13, 2021
@delete-merged-branch delete-merged-branch bot deleted the update-process-justification-and-finalization branch April 13, 2021 11:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants