Refactor signature function's argument #8773
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
farazdagi
reviewed
Apr 15, 2021
| @@ -98,8 +98,8 @@ func VerifySigningRoot(obj fssz.HashRoot, pub, signature, domain []byte) error { | |||
| } | |||
|
|
|||
| // VerifyBlockSigningRoot verifies the signing root of a block given it's public key, signature and domain. | |||
| func VerifyBlockSigningRoot(blk *ethpb.BeaconBlock, pub, signature, domain []byte) error { | |||
| set, err := BlockSignatureSet(blk, pub, signature, domain) | |||
| func VerifyBlockSigningRoot(rootFunc func() ([32]byte, error), pub, signature, domain []byte) error { | |||
There was a problem hiding this comment.
While on it, probably it is worth moving rootFunc argument to the end of argument list (for consistency, similar to core/blocks/signature.go:BlockSignatureSet())?
farazdagi
reviewed
Apr 15, 2021
| @@ -120,13 +120,13 @@ func VerifyBlockSigningRoot(blk *ethpb.BeaconBlock, pub, signature, domain []byt | |||
|
|
|||
| // BlockSignatureSet retrieves the relevant signature, message and pubkey data from a block and collating it | |||
| // into a signature set object. | |||
| func BlockSignatureSet(blk *ethpb.BeaconBlock, pub, signature, domain []byte) (*bls.SignatureSet, error) { | |||
| func BlockSignatureSet(rootFunc func() ([32]byte, error), pub, signature, domain []byte) (*bls.SignatureSet, error) { | |||
farazdagi
approved these changes
Apr 15, 2021
Codecov Report
@@ Coverage Diff @@
## develop #8773 +/- ##
===========================================
+ Coverage 60.54% 60.56% +0.01%
===========================================
Files 519 519
Lines 36271 36274 +3
===========================================
+ Hits 21962 21969 +7
+ Misses 11144 11141 -3
+ Partials 3165 3164 -1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivated by #8638
Flat out the following arguments so functions extensible for future hard forks to not use versioned block
VerifyBlockSignature->proposerIndex types.ValidatorIndex, sig []byte, rootFunc func() ([32]byte, error)BlockSignatureSet->proposerIndex types.ValidatorIndex, sig []byte, rootFunc func() ([32]byte, error)RandaoSignatureSet->reveal []byteVerifyBlockSigningRoot->rootFunc func() ([32]byte, error)