Fix comments #8802
Merged
Fix comments #8802
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rkapka
reviewed
Apr 23, 2021
| @@ -122,13 +124,15 @@ type resubscribeSub struct { | |||
| waitTime, backoffMax time.Duration | |||
| } | |||
|
|
|||
| // Unsubscribe unsubscribes from subscription. | |||
There was a problem hiding this comment.
There was a problem hiding this comment.
What can I say, it is a simple method to unsubscribe from the subscription :)
nisdas
approved these changes
Apr 23, 2021
Codecov Report
@@ Coverage Diff @@
## develop #8802 +/- ##
===========================================
+ Coverage 60.57% 60.59% +0.01%
===========================================
Files 520 520
Lines 36256 36258 +2
===========================================
+ Hits 21961 21969 +8
- Misses 11122 11125 +3
+ Partials 3173 3164 -9 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
What does this PR do? Why is it needed?
Which issues(s) does this PR fix?
N/A
Other notes for review