Optimized Slasher Database Methods #8805
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
farazdagi
approved these changes
Apr 23, 2021
| const ( | ||
| // DatabaseFileName is the name of the beacon node database. | ||
| DatabaseFileName = "slasher.db" | ||
| boltAllocSize = 8 * 1024 * 1024 |
There was a problem hiding this comment.
Can you add a comment to explain what this is please?
| "github.com/prysmaticlabs/prysm/shared/testutil/require" | ||
| ) | ||
|
|
||
| // setupDB instantiates and returns a Store instance. |
There was a problem hiding this comment.
Do you want to test some of the other things in kv.go? Perhaps testing the buckets were created.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
What does this PR do? Why is it needed?
This PR adds core slasher database methods from #8331. All code in this PR has already been reviewed and merged into branch feature/slasher already, but we are merging this into develop for an easier review of the feature branch later.
Which issues(s) does this PR fix?
Part of #8331