Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Validate Big Number Strings Better #8822

Merged
merged 2 commits into from
Apr 27, 2021
Merged

Validate Big Number Strings Better #8822

merged 2 commits into from
Apr 27, 2021

Conversation

nisdas
Copy link
Member

@nisdas nisdas commented Apr 27, 2021

What type of PR is this?

Bug Fix

What does this PR do? Why is it needed?

  • Removes the arbitrary padding of bytes to provided big number strings.
  • Add unit test.

Which issues(s) does this PR fix?

Resolves #8819

Other notes for review

@nisdas nisdas requested a review from a team as a code owner April 27, 2021 02:26
@nisdas nisdas requested review from kasey, terencechain and rkapka April 27, 2021 02:26
@nisdas nisdas merged commit 5c9f361 into develop Apr 27, 2021
@delete-merged-branch delete-merged-branch bot deleted the validateBetter branch April 27, 2021 06:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rauljordan rauljordan rauljordan approved these changes

@kasey kasey Awaiting requested review from kasey

@terencechain terencechain Awaiting requested review from terencechain

@rkapka rkapka Awaiting requested review from rkapka

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Missing input validation in SecretKeyFromBigNum
2 participants
@nisdas @rauljordan