Revert "Simplify Effective Balance Calculation (#8743)" #8844
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 45d2df1.
Codecov Report
@@ Coverage Diff @@
## develop #8844 +/- ##
===========================================
- Coverage 60.61% 60.55% -0.07%
===========================================
Files 525 525
Lines 36854 36871 +17
===========================================
- Hits 22340 22328 -12
- Misses 11298 11328 +30
+ Partials 3216 3215 -1 |
|
Can we toggle this as a feature flag or is this the end for this feature? |
prestonvanloon
approved these changes
Apr 30, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Feature Reversion
What does this PR do? Why is it needed?
Which issues(s) does this PR fix?
N.A
Other notes for review